Skip to content

Add hint as to what might be wrong when invalid identifiers are used #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Seldaek
Copy link
Contributor

@Seldaek Seldaek commented Jul 12, 2024

Went on a wild goose hunt to figure out if I needed to register my new identifier somewhere to make it valid before ultimately realizing I used foo_bar and that's not legal πŸ€¦πŸ»β€β™‚οΈ

@ondrejmirtes ondrejmirtes merged commit 2505e94 into phpstan:1.11.x Jul 12, 2024
452 of 455 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Underscore would probably be harmless but we kind of already settled on camelCaps.camelCaps 😊

@Seldaek
Copy link
Contributor Author

Seldaek commented Jul 12, 2024

Yeah it's totally fine, just wasn't clear at all from the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants